Task: Keep each FX convention's ORE id
Table of Contents
This page documents a task in the Complete the ORE report configuration story. It captures the goal, current status, acceptance, and any notes or results.
1. Goal
An FX convention keeps the id its document gave it, so every reference to it by that id resolves and the conventions export writes it back unchanged.
2. Status
| Field | Value |
|---|---|
| State | BACKLOG |
| Parent story | Complete the ORE report configuration |
| Now | Not yet started. |
| Waiting on | Nothing. |
| Next | Begin implementation. |
| Last touched | 2026-10-03 |
3. Acceptance
- Every FX convention in the corpus is stored under its own id, including the 600 or more that do not end in -FX-CONVENTIONS.
- A currency pair can hold more than one FX convention, as FX-BOE-USD-CAD and USD-CAD-FX do in one file.
- ores_refdata_validate_convention_id_fn resolves an FX convention by its stored id, and the conventions round trip asserts the id instead of documenting its loss.
- The document store writes FX conventions as world data, added only when the tenant lacks them, so a run import no longer skips them; the run store test expects none skipped.
4. Plan
(Implementation strategy. Written when work starts; key decisions
are distilled into the parent story's * Decisions at close, but the
plan itself stays — it is the historical record of what we did.)
5. Measurements
Every number this task claims about a tree, with the command that produced it
and the commit it was measured at. A number without both is not a measurement,
because a clean-up record describes a tree and trunk moves under a branch: a
consumer count, a gate's component count and a suite's size all change with no
code changing, and the reader of a bare number cannot tell which tree it came
from. Where the raw output matters, put it in an evidence/ file beside the
task and name that file in the Command column.
| What | Value | Command | Commit |
|---|---|---|---|
6. Notes
7. Test Scenarios
Manual QA scenarios (scaffolded via compass add test_scenario)
that verify this task. Link
new ones here as they're created; the scenario doc itself links back
via its "Verifies task" field.
| Scenario | State | Notes |
|---|---|---|
8. PRs
| PR | Title |
|---|---|
9. Review
| Comment summary | File | Decision | Notes |
|---|---|---|---|