Add regression tests for onboarding.party wizard-completion checks
Table of Contents
This page is a capture in the next bucket of the product backlog — a pre-sprint idea, not yet pulled into a sprint as a story.
What
Add automated test coverage for the onboarding.party
wizard-completion mechanism introduced in PR #1491:
auth_handler.hpp's single-party login path andaccount_handler.hpp'sselect_partypath: cases foronboarding.party=false(party_setup_required=true),onboarding.party=true+ partyActive(both flags false/empty), andonboarding.party=true+ party stillInactive(party_setup_required=false,party_setup_warningset).system_setting_handler::complete_party_onboarding— the new permission-check-free NATS handler.system_settings_service's newis_onboarding_*_complete=/=set_onboarding_*_completeaccessors.
Why
None of this had test coverage before or after PR #1491 (matching the
existing untested bootstrap_mode precedent, but flagged during
review as worth closing given this is the second time a
party-provisioner-wizard re-trigger bug has been fixed in this area).
A regression test would lock in the fix and catch future drift in the
party.status vs onboarding.party distinction.