Reconcile SQL codegen template drift on synthetic validation fn
Table of Contents
This page is a capture in the next bucket of the product backlog — a pre-sprint idea, not yet pulled into a sprint as a story.
What
Regenerating projects/ores.synthetic/modeling/ores.synthetic.fx_spot_generation_config.org
via compass codegen generate --model ... --address ores.sql (done to add
ou to the process_type check constraint for the GMM-improvements
story) produced a diff that, besides the intended check-constraint
change, also silently dropped custom validation logic from the
tracked ores_synthetic_validate_fx_spot_generation_config_fn()
function in
projects/ores.sql/create/synthetic/synthetic_fx_spot_generation_configs_create.sql:
the "system tenant canonical set" pass-through/fallback branch (the
block starting "Allow pass-through if neither this tenant nor the
system tenant has seeded active fx_spot_generation_configs yet…")
was replaced by a simpler null-check-only body. Either the
sql_schema_domain_entity_create.mustache template (or the model's
* Validation function section) has drifted behind manual edits
previously made to the generated file, or the template itself
regressed. The regeneration was reverted; only the single
check-constraint line was hand-edited instead, to avoid losing the
validation logic.
Why
Someone should compare the template output against the tracked file for this entity (and possibly others sharing the same template) and reconcile — either port the system-tenant fallback logic into the model/template properly, or determine it was an unintentional manual patch that should be redone as a template change. Left as-is, any future full regeneration of this entity's SQL layer will silently regress tenant validation behaviour.
References
projects/ores.sql/create/synthetic/synthetic_fx_spot_generation_configs_create.sqlprojects/ores.synthetic/modeling/ores.synthetic.fx_spot_generation_config.org