Sweep missing reflectors.hpp IWYU include across entity repositories
Table of Contents
This page is a capture in the next bucket of the product backlog — a pre-sprint idea, not yet pulled into a sprint as a story.
What
Run compass codegen entity generate <name> for every entity whose
*_entity.cpp is missing the ores.utility/rfl/reflectors.hpp IWYU
include (// IWYU pragma: keep.) that cpp_domain_type_entity.cpp.mustache
emits unconditionally, then commit the resulting diffs. A repo-wide grep
found only 5 of ~148 *_entity.cpp files currently have it (party_type,
post PR #1407, plus 4 files under ores.marketdata); the rest — including
purpose_type_entity.cpp, previously assumed clean — are all stale
relative to the current template.
Why
Discovered as a side-finding during the claude-review of PR #1407 (party_type
codegen resync): the missing-include drift is systemic across the codebase,
not isolated to party_type=/=party_status as the commissioning story
currently documents. Left unaddressed, compass codegen entity show will
keep reporting drift one entity at a time as each is touched, rather than
being swept in one pass.