Story: Engineering hygiene
Table of Contents
This page documents a story in Sprint 09. It captures the goal, current status, acceptance criteria, and the tasks that compose it.
Goal
Three independent hygiene strands: bring system + component models
back in sync; consolidate PR-handling skills behind a single
pr-manager; resolve the valgrind regressions. A fourth strand —
documentation refactor — is postponed.
Status
| Field | Value |
|---|---|
| State | DONE |
| Parent sprint | Sprint 09 |
| Now | Completed 2026-01-14. |
| Waiting on | None. |
| Next | None. |
| Last touched | 2026-01-14 |
Acceptance
- System + component models refreshed and a skill in place to keep them so.
- PR-handling skills consolidated into
pr-manager. - Nightly valgrind green.
- Documentation refactor scoped and parked as BACKLOG.
Tasks
| Task | State | Start | End | Description |
|---|---|---|---|---|
| Clean up system models and component models | DONE | 2026-05-19 | 2026-01-12 | Refresh system + component models out of sync with recent refactorings; introduce component-model-creator skill; new component docs for ores.logging, ores.http, ores.http.server, ores.wt. |
| Refactor PR-related skills into pr-manager | DONE | 2026-05-19 | 2026-01-12 | Rename pr-summary -> pr-manager; consolidate the 5-step PR lifecycle; remove duplicated PR creation logic from autonomous developer skills. |
| Fix valgrind errors in nightly | DONE | 2026-05-19 | 2026-01-14 | Eventing tests fail under clang valgrind; one new possible leak on both clang and gcc. |
| Refactor documentation per entity | BACKLOG | 2026-05-19 | Split recipes per entity; create a top-level domain document per entity that cross-references recipes, component model, entity implementation files (SQL included), and skills. Recipes attach to components rather than being global. |
Decisions
- Skill-as-process for new components
- the
component-model-creatorskill ensures that every new component lands with a model rather than being added retroactively. - One PR skill, not five
- removes the drift between the multiple skills that all knew how to draft a PR.
- Documentation refactor merges into v2
- rather than landing the split-recipes-per-entity work twice (once in v0, again in v2), let v2 carry it.
Out of scope
- Per-entity documentation layout — superseded by v2.
See also
None.