Task: Extend compass review list to conversation-level comments
This page documents a task in the Add PR management support to compass story. It captures the goal, current status, acceptance, and any notes or results.
Goal
compass review list only showed line-level review comments, so the
review-round runbook still needed gh pr view --comments for review
summaries and bot banners. Extend list with a Conversation section
sourced from the PR's issue comments and review summaries (state-only
reviews with no body are dropped), so one command reads the whole
review surface.
Status
| Field | Value |
|---|---|
| State | DONE |
| Parent story | Add PR management support to compass |
| Now | Nothing. |
| Waiting on | Nothing. |
| Next | Nothing. |
| Last touched | 2026-06-05 |
Acceptance
compass review list <pr>shows line comments and conversation items (issue comments + review summaries with bodies), in chronological order, with--detailand--format jsoncovering both.- The review-round runbook and the address-review-comments recipe no
longer reference
gh pr view --comments.
Plan
(Transient implementation strategy. Written when work starts;
distilled into the parent story's * Decisions and cleared when the
task closes. Plans do not outlive their task.)
Notes
PRs
| PR | Title |
|---|---|
| #1081 | [ores.compass] Extend review list to conversation-level comments |
Review
| # | Comment summary | File | Decision | Notes |
|---|---|---|---|---|
| 1 | created_at null in JSON bypasses dict.get default → sort TypeError | compass_review.py | Accepted | or ""; b378ad8a1 |
| 2 | submitted_at null (pending reviews) → same TypeError | compass_review.py | Accepted | or ""; b378ad8a1 |
Result
Shipped in PR #1081 (merged 2026-06-05): review list shows line
threads plus a Conversation section (issue comments and review
summaries, chronological, null-timestamp safe); --detail and json
({line, conversation}) cover both. The runbook and recipe dropped
their last gh pr view --comments reference.