Task: Verify currency shell commands and NATS integration
This page documents a task in the Commission: currency story. It captures the goal, current status, acceptance, and any notes or results.
Goal
Run all four currency shell commands (list, add, remove, history) in ores.shell against
a live service and verify correct behaviour post-NATS migration. A successful shell run
also validates NATS end-to-end: the shell issues NATS requests, receives responses, and
mutations trigger NATS events. Fix any regressions found.
Status
| Field | Value |
|---|---|
| State | DONE |
| Parent story | Commission: currency |
| Now | Nothing. |
| Waiting on | Nothing. |
| Next | None. |
| Last touched | 2026-06-03 |
Acceptance
listcommand returns records from the live service.addcommand creates a record; record appears in subsequent list.removecommand deletes the record; record no longer appears in list.historycommand returns the change history for the deleted record.- NATS event fired on add and remove (observable via NATS subscriber or second session).
- Any regressions found are fixed or filed as captures.
- Findings recorded in
* Resultsection. - Site builds cleanly.
PRs
| PR | Title |
|---|---|
| #959 | [ores.shell] Fix mTLS, stale NATS subjects, and currencies bugs |
Review
| # | Comment summary | File | Decision | Notes |
|---|---|---|---|---|
| 1 | Unnecessary std::string() wrap on bootstrap_status subject |
application.cpp | Accept | Fixed 29ab304f |
| 2 | Unnecessary std::string() wrap on create_initial_admin subject |
accounts_commands.cpp | Accept | Fixed 29ab304f |
| 3 | Unnecessary std::string() wrap on bootstrap_status subject |
connection_commands.cpp | Accept | Fixed 29ab304f |
Result
All four shell commands (list, add, remove, history) verified against a live service. NATS end-to-end confirmed: requests issued and responses received for mutations; events observable in a second session.
Regressions found and fixed in PR #959:
- mTLS configuration was broken post-NATS migration.
- Several NATS subjects were stale (pre-migration names).
- Currencies-specific bugs in the shell command implementations.
Three review comments (unnecessary std::string() wraps on NATS subjects) fixed in
follow-up commit 29ab304f. PR merged 2026-05-31.