Task: Render currency's monetary_nature and market_tier combos as badges
Table of Contents
This page documents a task in the Commission: currency story. It captures the goal, current status, acceptance, and any notes or results.
Goal
Currency's monetary_nature and market_tier combos currently show
plain text (via the populateDynamicCombo<Entity> mechanism landed
in task 318EE3EB). Render them as colored badges instead, matching
Book's book_status field (setup_badge_combo=/=BadgeCache, see
clever_dijkstra worktree's book-status work if not yet merged into
main).
book_status is a static_combo field with a fixed value set and a
badge_key property — BadgeCache presumably keys off a small, known
enum. monetary_nature=/=market_tier are dynamic, server-fetched
reference-table combos (populateDynamicCombo<Entity>, not
static_combo), so the existing badge mechanism doesn't apply
as-is. This task needs to either:
- extend the badge mechanism to work with dynamically-fetched combo
items (badge color keyed off each item's
code, not a static enum), or - find that the fetched reference-table rows already carry a badge color mapping the server can express, or
- conclude it's not a good fit and document why.
Status
| Field | Value |
|---|---|
| State | DONE |
| Parent story | Commission: currency |
| Now | Complete. |
| Waiting on | Nothing. |
| Next | None. |
| Last touched | 2026-07-10 |
Acceptance
monetary_natureandmarket_tiercombos render colored badges matchingbook_status's visual pattern, OR a documented reason they can't/shouldn't (e.g. mechanism mismatch, no natural badge color source) with the decision recorded here.- Build passes.
Plan
(Implementation strategy. Written when work starts; key decisions
are distilled into the parent story's * Decisions at close, but the
plan itself stays — it is the historical record of what we did.)
Notes
PRs
| PR | Title |
|---|---|
Review
| Comment summary | File | Decision | Notes |
|---|---|---|---|
Result
Done, but never marked as such. badge_key/is_badge are set for both monetary_nature and market_tier, in both the detail-dialog combos and the list-window columns (currency.org's * Detail fields and
Columns tables), landed in commit 43b5c1a16 ("Badge-annotate
currency combos").