Task: Currency Pair Conventions list/detail have no flags for the pair
This page documents a task in the Currency pair support in reference data story. It captures the goal, current status, acceptance, and any notes or results.
Goal
The Currency Pair Conventions list and detail dialog show the
Pair column/field as plain text (e.g. "USD/KWD") with no flags,
unlike Currency Pairs. Apply the same base/quote combined-flag
treatment used there (including the sizing fix from
Currency pair flag icons in list are too small), to both the list
and the detail dialog.
Status
| Field | Value |
|---|---|
| State | DONE |
| Parent story | Currency pair support in reference data |
| Now | Nothing. |
| Waiting on | Nothing. |
| Next | Nothing. |
| Last touched | 2026-07-08 |
Acceptance
[ ]Currency Pair Conventions list'sPaircolumn shows the base/quote flag icon, same size/style as Currency Pairs.[ ]Currency Pair Conventions detail dialog shows the same flag treatment for its pair field.
Plan
(Implementation strategy. Written when work starts; key decisions
are distilled into the parent story's * Decisions at close, but the
plan itself stays — it is the historical record of what we did.)
Notes
PRs
| PR | Title |
|---|---|
Review
| Comment summary | File | Decision | Notes |
|---|---|---|---|
Result
Delivered as part of PR #1472 (task DAE530F1). List: new Icon columns
(Qt model) entry splitting pair_code via
currency_flag_icon_from_pair_code(). Detail: new inline key-field
flag via DetailDialogBase::has_key_flag_icon (split out from the
existing has_flag_icon, which assumes an entity owns an uploadable
image_id — conventions has none, its icon is purely derived from
pair_code).