Story: Hotfix: Windows -Werror deprecated-declarations on std::getenv in compute_commands.cpp
Table of Contents
This page documents a story in Sprint 24. It captures the goal, current status, acceptance criteria, and the tasks that compose it.
Goal
Windows clang-cl CI builds green again: compute_commands.cpp no longer trips -Werror=deprecated-declarations on std::getenv.
Status
| Field | Value |
|---|---|
| State | DONE |
| Parent sprint | Sprint 24 |
| Now | Nothing. |
| Waiting on | Nothing. |
| Next | Nothing. |
| Last touched | 2026-08-03 |
Acceptance
- projects/ores.shell/src/app/commands/compute_commands.cpp no longer calls std::getenv; uses ores::platform::environment::environment::get_value_or_default() instead.
- No other stray std::getenv/::getenv calls remain outside ores.platform's own implementation.
Tasks
| Task | State | Start | End | Description |
|---|---|---|---|---|
| Scaffold story: Hotfix: Windows -Werror deprecated-declarations on std::getenv in compute_commands.cpp | DONE | 2026-08-03 | 2026-08-03 | Story scaffolding rides this task: documents, sprint wiring, and the scaffold PR. Close it before merging that PR. |
| Implement Hotfix: Windows -Werror deprecated-declarations on std::getenv in compute_commands.cpp | DONE | 2026-08-03 | 2026-08-03 | Initial task for: Hotfix: Windows -Werror deprecated-declarations on std::getenv in compute_commands.cpp |
Decisions
- Same fix pattern as the prior systemd_notify.cpp hotfix (530a5f97b): use ores::platform::environment::environment's helper rather than std::getenv directly, since it already handles the Windows deprecation warning internally.