Task: Implement Hotfix: the ER diagram no longer matches the SQL tree
Table of Contents
This page documents a task in the Hotfix: the ER diagram no longer matches the SQL tree story. It captures the goal, current status, acceptance, and any notes or results.
1. Goal
Take the drift job green for every pull request.
2. Status
| Field | Value |
|---|---|
| State | DONE |
| Parent story | Hotfix: the ER diagram no longer matches the SQL tree |
| Now | Nothing. |
| Waiting on | Nothing. |
| Next | Nothing. |
| Last touched | 2026-10-01 |
3. Acceptance
- The two commands the drift job runs pass, including
--check. - The diff is the tables and comments the recent merges added.
4. Plan
- Run the job's parse and render commands from the job itself.
- Regenerate the diagram and re-run the check.
- Commit, and re-run the other open pull request's checks afterwards.
5. Measurements
| What | Value | Command | Commit |
|---|---|---|---|
| The check before | exit 1 | plantuml_er_generate.py ... --check |
main at ee9c6f2a |
| Tables in the render | 361, across 22 packages | plantuml_er_parse_sql.py ... --warn |
this branch |
| The check after | ores_schema.puml is up to date, exit 0 |
plantuml_er_generate.py ... --check |
this branch |
| The diff | 10 insertions, 7 deletions | git diff --stat |
this branch |
6. Notes
- The generator needs
pystache, which lives in the codegen virtual environment, so the render runs underprojects/ores.codegen/venv/bin/pythonrather than the system interpreter the workflow uses (there, the requirements are installed into the runner's Python).
7. PRs
| PR | Title |
|---|---|
| #2458 | Regenerate the ER diagram the SQL tree drifted away from |
8. Review
| Comment summary | File | Decision | Notes |
|---|---|---|---|
9. Result
ores_schema.puml matches a fresh render of the 361 tables across 22
packages, and the check the drift job runs exits 0.