Task: Call the firm's own id the trade id throughout the knowledge notes
Table of Contents
This page documents a task in the Design the trade shape on data-oriented principles story. It captures the goal, current status, acceptance, and any notes or results.
1. Goal
Use trade id, never deal id, for the firm's own identifier of a trade, as the trade shape design decided.
2. Status
| Field | Value |
|---|---|
| State | DONE |
| Parent story | Design the trade shape on data-oriented principles |
| Now | Nothing. |
| Waiting on | Nothing. |
| Next | Nothing. |
| Last touched | 2026-10-03 |
3. Acceptance
- No knowledge note uses deal id or Deal ID for the firm's own trade identifier.
4. Plan
(Implementation strategy. Written when work starts; key decisions
are distilled into the parent story's * Decisions at close, but the
plan itself stays — it is the historical record of what we did.)
5. Measurements
Every number this task claims about a tree, with the command that produced it
and the commit it was measured at. A number without both is not a measurement,
because a clean-up record describes a tree and trunk moves under a branch: a
consumer count, a gate's component count and a suite's size all change with no
code changing, and the reader of a bare number cannot tell which tree it came
from. Where the raw output matters, put it in an evidence/ file beside the
task and name that file in the Command column.
| What | Value | Command | Commit |
|---|---|---|---|
6. Notes
Known scope, measured on main when the task was scaffolded:
trade_blotter.org, lines 105 and 344: the blotter's Deal ID column.positions.org, line 39: "a unique deal id".dynamic_books.org, lines 27 and 31, andbooks_and_portfolios.org, line 137: deal ID as a filter field.
Not in scope, and not to be renamed to trade id: "OS deal ID" in
trade_blotter.org, lines 276 and 389. That is the originating system's
identifier for the trade, which is a scheme in trade_identifier, not
the firm's own trade id. Rename it to the originating-system
identifier, so the two are not confused.
7. Test Scenarios
Manual QA scenarios (scaffolded via compass add test_scenario)
that verify this task. Link
new ones here as they're created; the scenario doc itself links back
via its "Verifies task" field.
| Scenario | State | Notes |
|---|---|---|
8. PRs
| PR | Title |
|---|---|
| #2524 | [doc] Call the firm's own id the trade id throughout the knowledge notes |
9. Review
| Comment summary | File | Decision | Notes |
|---|---|---|---|
10. Result
The knowledge notes call the firm's own identifier the trade id. Six
uses changed: the blotter's column and the mini-blotter header in
trade_blotter.org, the identity row of positions.org, the filter
example and the property list in dynamic_books.org, and the property
list in books_and_portfolios.org. The originating system's deal ID in
trade_blotter.org is now the originating-system identifier: it is a scheme in
trade_identifier, not the trade id. No durable document outside the
agile records still says deal id; the agile records are history and
keep their words.