Task: Author the TaRF fact table
Table of Contents
This page documents a task in the Rework the equity instruments to the instrument table rule story. It captures the goal, current status, acceptance, and any notes or results.
1. Goal
A target redemption forward's own terms have a table, and its target is not written into an accumulator's columns.
2. Status
| Field | Value |
|---|---|
| State | DONE |
| Parent story | Rework the equity instruments to the instrument table rule |
| Now | Nothing. |
| Waiting on | Nothing. |
| Next | Nothing. |
| Last touched | 2026-10-18 |
3. Acceptance
4. Plan
(Implementation strategy. Written when work starts; key decisions
are distilled into the parent story's * Decisions at close, but the
plan itself stays — it is the historical record of what we did.)
5. Measurements
Every number this task claims about a tree, with the command that produced it
and the commit it was measured at. A number without both is not a measurement,
because a clean-up record describes a tree and trunk moves under a branch: a
consumer count, a gate's component count and a suite's size all change with no
code changing, and the reader of a bare number cannot tell which tree it came
from. Where the raw output matters, put it in an evidence/ file beside the
task and name that file in the Command column.
| What | Value | Command | Commit |
|---|---|---|---|
6. Notes
7. Test Scenarios
Manual QA scenarios (scaffolded via compass add test_scenario)
that verify this task. Link
new ones here as they're created; the scenario doc itself links back
via its "Verifies task" field.
| Scenario | State | Notes |
|---|---|---|
8. PRs
| PR | Title |
|---|---|
| #3502 | [trading] Author the TaRF fact table |
9. Review
| Comment summary | File | Decision | Notes |
|---|---|---|---|
10. Result
The target redemption forward has its own fact table. The product's subject matter is the target, and an accumulator has neither a target amount nor target points, which is why the code could not keep routing to equity_accumulator_instruments.
The table is authored from the ORE binding: the underlying, the currency, the fixing amount, the target amount and points and the strike. The fixing amount, the target amount and the strike are money, so all three are exact decimals. Target points are a count of observations rather than an amount, so they stay a continuous quantity. The target amount, the points and the strike are optional because the document may state a strike list instead of one strike, and the barrier that ends the product belongs with the shared strike child.
Verification. Full build clean, the database recreated, the whole suite passes 96 of 96, ores.trading.core.tests passes 1196 assertions in 178 cases, and the table is present in the database after the recreate.
Not done, and named: no mapper writes the table and EquityTaRF still routes to equity_accumulator_instruments. Both move with the mapper migration.