Task: Test the equity position underlying
Table of Contents
This page documents a task in the Rework the equity instruments to the instrument table rule story. It captures the goal, current status, acceptance, and any notes or results.
1. Goal
The position underlying entity carries the same generated test coverage as the family's other entities.
2. Status
| Field | Value |
|---|---|
| State | DONE |
| Parent story | Rework the equity instruments to the instrument table rule |
| Now | Nothing. |
| Waiting on | Nothing. |
| Next | Nothing. |
| Last touched | 2026-10-17 |
3. Acceptance
4. Plan
(Implementation strategy. Written when work starts; key decisions
are distilled into the parent story's * Decisions at close, but the
plan itself stays — it is the historical record of what we did.)
5. Measurements
Every number this task claims about a tree, with the command that produced it
and the commit it was measured at. A number without both is not a measurement,
because a clean-up record describes a tree and trunk moves under a branch: a
consumer count, a gate's component count and a suite's size all change with no
code changing, and the reader of a bare number cannot tell which tree it came
from. Where the raw output matters, put it in an evidence/ file beside the
task and name that file in the Command column.
| What | Value | Command | Commit |
|---|---|---|---|
6. Notes
7. Test Scenarios
Manual QA scenarios (scaffolded via compass add test_scenario)
that verify this task. Link
new ones here as they're created; the scenario doc itself links back
via its "Verifies task" field.
| Scenario | State | Notes |
|---|---|---|
8. PRs
| PR | Title |
|---|---|
| #3488 | [trading] Test the equity position underlying |
9. Review
| Comment summary | File | Decision | Notes |
|---|---|---|---|
10. Result
The position underlying carries the generated eventing integration test now, and enabling it exposed three defects that nothing had exercised, because this is the family's first child entity with a test at all.
The generated test wrote its trade under the harness context, so the trade's party was not a party row and the insert refused it. The model documents :party_scoped_writes: for exactly this shape, a row whose party comes from a parent it does not model, and it was not set.
The generator left sequence_number at zero, which the table's own check refuses, and filled four enumerated columns with random nouns, which their checks refuse. The model declares the ordinal and pins one legal value per enumerated column.
Verification. Full build clean, and ores.trading.core.tests passes 1196 assertions in 178 cases, the new one included. The whole suite passes 95 of 96. The exception is ores.iam.core.tests, which fails only after the whole suite has run and passes 1197 assertions in 303 cases immediately after a database recreate, reproduced twice. That is a cross-suite database isolation defect in the IAM tests and not something this change touches.
Not done, and named: the credit basket constituent generator has the same zero and random-noun defects, and no test reaches them. It is another family's, and the fix belongs beside its own test.