Task: Correct the value sets against the ORE code
Table of Contents
This page documents a task in the Make every configuration screen follow one standard story. It captures the goal, current status, acceptance, and any notes or results.
1. Goal
Every seeded value set states what ORE 1.8.17 accepts for its parameter, and the two catalogue sets that were text because their registry held words now check a document again.
2. Status
| Field | Value |
|---|---|
| State | DONE |
| Parent story | Make every configuration screen follow one standard |
| Now | Nothing. |
| Waiting on | Nothing. |
| Next | Nothing. |
| Last touched | 2026-10-30 |
3. Acceptance
4. Plan
(Implementation strategy. Written when work starts; key decisions
are distilled into the parent story's * Decisions at close, but the
plan itself stays — it is the historical record of what we did.)
5. Measurements
Every number this task claims about a tree, with the command that produced it
and the commit it was measured at. A number without both is not a measurement,
because a clean-up record describes a tree and trunk moves under a branch: a
consumer count, a gate's component count and a suite's size all change with no
code changing, and the reader of a bare number cannot tell which tree it came
from. Where the raw output matters, put it in an evidence/ file beside the
task and name that file in the Command column.
| What | Value | Command | Commit |
|---|---|---|---|
6. Notes
7. Test Scenarios
Manual QA scenarios (scaffolded via compass add test_scenario)
that verify this task. Link
new ones here as they're created; the scenario doc itself links back
via its "Verifies task" field.
| Scenario | State | Notes |
|---|---|---|
8. PRs
9. Review
| Comment summary | File | Decision | Notes |
|---|---|---|---|
10. Result
The audit's findings are applied, and the three that do not hold are stated in the investigation with their evidence.
- Eleven sets that stated text became the list or the switch ORE reads:
bounds,timingadjustment,bootstrap_mode,yieldcurvemodel,infmodeltype,floatspreadmapping,irvolatilitytype,regression_vargroupmode,heston_calibrationmethod,heston_processdiscretizationandtrainingsamples;globalmodel,useadanduseindexcurveforindexcdsbecame boolean sets. - Nine sets that stated text became numbers:
displacement,irreversion,infjyrealratereversion,bootstrap_mesherconcentration,regressionvariancecutoffand the three smoothing settings. - The bounds ORE enforces are stated:
betaand 21 whole numbers stored in a QuantLibSizetake a floor of 0, and the four seeds are left signed, as ORE reads them. calibrationstrategygainedUnderlyingATMandUnderlyingDealStrike, andschemegainedGaussLobattowith its description naming the two engine families the union serves.- The period patterns accept a signed period, and the interpolation method set
gained the deprecated
DefaultLogMixedLinearCubicalias. curve.business_day_conventionandcurve.day_counterare catalogue sets again. The business day convention catalogue states the 26 spellings ORE's parser maps onto seven conventions, and the day counter registry already held ORE's spellings.
Not applied, and recorded with the evidence: Model and Engine (the
population holds fifteen or more builder names and the valid one depends on the
product type) and Calibration (five values in the IR builders, an unvalidated
string in a scripted trade).
Verified live: the catalogue views answer 26 and 71 values, the guard accepts
F and Following and refuses XX, and ore_parameter_settings check
answers OK over 266 drawn parameters. The nine C++ suites and the 639-test
pgTAP suite pass.