Task: Complete the result row's generation

Table of Contents

This page documents a task in the Prove the report grid run end to end — the remaining work story. It captures the goal, current status, acceptance, and any notes or results.

1. Goal

The reporting component regenerates to exactly what is committed, a run's rows are read through the generated handler, which honours the page, the filters and the read permission, and posting a run leaves every earlier run's rows live.

2. Status

Field Value
State DONE
Parent story Prove the report grid run end to end — the remaining work
Now Nothing.
Waiting on Nothing.
Next Nothing.
Last touched 2026-10-28

3. Acceptance

  • check_component_drift.py –component reporting exits zero.
  • A run's rows are read through reporting.v1.report_result_rows.list, and the service applies limit, offset and every filter member.
  • The read checks reporting::report_result_rows:read, and the permission is seeded and granted to Member.
  • The hand-written run_result_rows_handler and its read_by_run are gone.
  • Inserting a run's rows closes nothing of another run: the soft-update trigger names the natural key, which includes the run.
  • Codegen refuses a model that states the soft-update trigger without a bitemporal natural key, so the trigger cannot be generated with a tenant-wide close.

4. Plan

(Implementation strategy. Written when work starts; key decisions are distilled into the parent story's * Decisions at close, but the plan itself stays — it is the historical record of what we did.)

5. Measurements

Every number this task claims about a tree, with the command that produced it and the commit it was measured at. A number without both is not a measurement, because a clean-up record describes a tree and trunk moves under a branch: a consumer count, a gate's component count and a suite's size all change with no code changing, and the reader of a bare number cannot tell which tree it came from. Where the raw output matters, put it in an evidence/ file beside the task and name that file in the Command column.

What Value Command Commit
       

6. Notes

7. Test Scenarios

Manual QA scenarios (scaffolded via compass add test_scenario) that verify this task. Link new ones here as they're created; the scenario doc itself links back via its "Verifies task" field.

Scenario State Notes
     

8. PRs

PR Title
#3986 [reporting] Generate the result row's service and handler

9. Review

Comment summary File Decision Notes
       

10. Result

Merged as #3986. The entity regenerates to exactly what is committed: every layer, from the generator, and nothing hand-edited. A run's rows are read through the generated list, which applies the page, every filter member and the read permission, and answers the true total.

The generation also exposed the defect this task fixed beyond its first scope: the soft-update trigger closed every current row of the tenant before each insert, so posting a run erased the rows of every run before it. The model now states the natural key and the trigger names the run, so a run's rows stay live until something prunes them, and a re-post replaces only its own version.

Proven: the full tree builds; the three reporting suites pass; the trigger test left 24 current rows before an insert for another run and 25 after; the live read returns 24 rows through the generated path; and the reporting drift check exits zero. Codegen now refuses the trigger without a key.

The review's one open point, a generated list with no ceiling of its own, is captured rather than fixed here, because it is a page policy for every generated list and not this entity's fault.

Emacs 29.3 (Org mode 9.6.15)