Task: Read the trade a run failed on, at its version
Table of Contents
This page documents a task in the Prove the report grid run end to end — the remaining work story. It captures the goal, current status, acceptance, and any notes or results.
1. Goal
The trade a run failed on opens at the version the run read, and the screen says whether that version is still the current one.
2. Status
| Field | Value |
|---|---|
| State | DONE |
| Parent story | Prove the report grid run end to end — the remaining work |
| Now | Nothing. |
| Waiting on | Nothing. |
| Next | Nothing. |
| Last touched | 2026-10-25 |
3. Acceptance
- The blotter opens the trade the link names, at the version in the link.
- A version that no longer exists is said, not shown as a failure.
- A trade whose version the run did not record is named, not linked.
4. Plan
(Implementation strategy. Written when work starts; key decisions
are distilled into the parent story's * Decisions at close, but the
plan itself stays — it is the historical record of what we did.)
5. Measurements
Every number this task claims about a tree, with the command that produced it
and the commit it was measured at. A number without both is not a measurement,
because a clean-up record describes a tree and trunk moves under a branch: a
consumer count, a gate's component count and a suite's size all change with no
code changing, and the reader of a bare number cannot tell which tree it came
from. Where the raw output matters, put it in an evidence/ file beside the
task and name that file in the Command column.
| What | Value | Command | Commit |
|---|---|---|---|
6. Notes
7. Test Scenarios
Manual QA scenarios (scaffolded via compass add test_scenario)
that verify this task. Link
new ones here as they're created; the scenario doc itself links back
via its "Verifies task" field.
| Scenario | State | Notes |
|---|---|---|
8. PRs
| PR | Title |
|---|---|
| #3807 | [web] Open the trade a run failed on, at its version |
9. Review
| Comment summary | File | Decision | Notes |
|---|---|---|---|
10. Result
The blotter opens the trade a run failed on, at the version the run read.
The trades route gained GET /api/trades/:id/versions/:version, which asks the
trading service for the versioned trade rather than filtering a list the screen
already holds. The server answers a version the trade never had as a missing
answer, so the screen can say so instead of showing a read failure.
The trades page reads trade and version from its address and, when both are
there, shows the trade above the blotter with its type, state and trade date,
and the words saying that the blotter shows the current version. A version that
is not there is said in words. The error screen links a trade only when the run
recorded its version; otherwise it names the trade, because a link that lands on
an unfiltered blotter is worse than a name.
Proven in a browser: /trades?trade=26b4ff60-…&version=5 showed the panel with "Version 5", and version 99 said there is no such version.