Task: Fix the system lookups and the approval read
Table of Contents
This page documents a task in the Rework the market data feeds into a market data service with adapters — the remaining work story. It captures the goal, current status, acceptance, and any notes or results.
1. Goal
The cut families and rules answer any tenant, and a cut reader holds the approval kinds read.
2. Status
| Field | Value |
|---|---|
| State | DONE |
| Parent story | Rework the market data feeds into a market data service with adapters — the remaining work |
| Now | Nothing. |
| Waiting on | Nothing. |
| Next | Nothing. |
| Last touched | 2026-10-31 |
3. Acceptance
- The family and rule repositories admit the system tenant's rows.
- The cut-reader roles hold inbox::approval_kinds:read in the seed.
- The screens' choices and the types list answer for a normal role.
4. Plan
(Implementation strategy. Written when work starts; key decisions
are distilled into the parent story's * Decisions at close, but the
plan itself stays — it is the historical record of what we did.)
5. Measurements
Every number this task claims about a tree, with the command that produced it
and the commit it was measured at. A number without both is not a measurement,
because a clean-up record describes a tree and trunk moves under a branch: a
consumer count, a gate's component count and a suite's size all change with no
code changing, and the reader of a bare number cannot tell which tree it came
from. Where the raw output matters, put it in an evidence/ file beside the
task and name that file in the Command column.
| What | Value | Command | Commit |
|---|---|---|---|
6. Notes
7. Test Scenarios
Manual QA scenarios (scaffolded via compass add test_scenario)
that verify this task. Link
new ones here as they're created; the scenario doc itself links back
via its "Verifies task" field.
| Scenario | State | Notes |
|---|---|---|
8. PRs
| PR | Title |
|---|---|
| #4277 | [reporting] Read the system lookups from any tenant |
9. Review
| Comment summary | File | Decision | Notes |
|---|---|---|---|
10. Result
Two defects found by live testing are fixed.
- The cut families and resolution rules are the system tenant's rows, but their repositories filtered to the caller's tenant, so every tenant saw an empty list and the edit dialog's selects were empty. The models now carry system_tenant_visible, and the regenerated repositories admit the system tenant's rows; verified live: the shell lists 5 families and 7 rules, and /api/reporting/cut-kind-choices answers all four arrays.
- The cut types screen derives the signed-or-not from the inbox approval kind, so a cut reader needs inbox::approval_kinds:read. The seed now grants it to Member, Trading, Operations, Support, Viewer, Finance and ReportRun; the running tenant's roles were granted and the types list answers for henry.
- Checks: the reporting service rebuilt and restarted; the codegen regenerated the two repositories; the live shell and BFF verified.