Task: Refuse a portfolio a trade's party does not own
Table of Contents
This page documents a task in the Restore the trading guards the versioned model dropped — the remaining work story. It captures the goal, current status, acceptance, and any notes or results.
1. Goal
The versioned trading refactor removed the check that a trade is reported only in its own party's portfolios. The message is gone from the generated SQL, so a trade can be reported into any party's portfolio. Put the guarantee back, or record that it is deliberately gone.
2. Status
| Field | Value |
|---|---|
| State | BACKLOG |
| Parent story | Restore the trading guards the versioned model dropped — the remaining work |
| Now | Not yet started. |
| Waiting on | Nothing. |
| Next | Begin implementation. |
| Last touched | 2026-10-09 |
3. Acceptance
- A trade cannot be reported in another party's portfolio.
- The pgTAP suite that proves it is restored.
4. Plan
(Implementation strategy. Written when work starts; key decisions
are distilled into the parent story's * Decisions at close, but the
plan itself stays — it is the historical record of what we did.)
5. Measurements
Every number this task claims about a tree, with the command that produced it
and the commit it was measured at. A number without both is not a measurement,
because a clean-up record describes a tree and trunk moves under a branch: a
consumer count, a gate's component count and a suite's size all change with no
code changing, and the reader of a bare number cannot tell which tree it came
from. Where the raw output matters, put it in an evidence/ file beside the
task and name that file in the Command column.
| What | Value | Command | Commit |
|---|---|---|---|
6. Notes
7. Test Scenarios
Manual QA scenarios (scaffolded via compass add test_scenario)
that verify this task. Link
new ones here as they're created; the scenario doc itself links back
via its "Verifies task" field.
| Scenario | State | Notes |
|---|---|---|
8. PRs
| PR | Title |
|---|---|
9. Review
| Comment summary | File | Decision | Notes |
|---|---|---|---|