Code Review PR Skill

Table of Contents

When to use this skill

When reviewing changes in a pull request or a commit range — focused on the delta (changed files only), not a full component audit. For the latter, use code-review-component.

How to use this skill

  1. Scope the review. Identify the PR or commit range:

    gh pr diff <PR_NUMBER>
    # or
    git diff main...HEAD
    

    Categorise changed files by component and facet.

  2. Apply the checklist. The canonical list is Code review checklist — go through each category and check what applies to the changed files. Skip the Component-only checks section (those are for whole-component audits).
  3. File findings bucketed by severity (Critical / Important / Minor) as defined in the checklist. For each:
    • line — exact location.
    • What's wrong — clear description.
    • Why it matters — impact.
    • How to fix — concrete resolution if not obvious.
  4. Group findings into tasks or a story. For non-trivial fixes, open a new task in the current sprint, or a story if the review surfaces a coherent unit of work, via agile-product-owner.
  5. Verdict. Conclude with one of:

    • Ready to merge — no critical issues.
    • Ready with fixes — critical issues identified; must fix first.
    • Not ready — significant rework required.

    Add 1–2 sentences of reasoning.

Recipes

Reference

Emacs 29.1 (Org mode 9.6.6)