PR Address Review

Table of Contents

When to use this skill

Review comments arrived on a PR: handle one complete round — sync, read, decide, fix, push, reply, resolve, record.

How to use this skill

  1. Gate — confirm there is a round to handle: compass review list <N> --detail. No comments yet, or the reviewer still running → stop and wait. Every comment replied and threads resolved → round already done; stop. Never sync/rebase when there is nothing to address — it churns CI and forces a force-push.
  2. Sync with main:

    ./projects/ores.compass/compass.sh pr sync
    
  1. Check CI before reading comments — a failure may supersede them:

    ./projects/ores.compass/compass.sh pr checks <N>
    
  1. Read every comment:

    ./projects/ores.compass/compass.sh review list <N> --detail
    
  1. Decide per comment — explicit accept or decline; never silently ignore.
  2. Fix — one commit per logical fix; never amend on a branch under review. Push.
  3. Reply to every comment — accepted: "Fixed in <sha> — …"; declined: "Not changed. <reason>":

    ./projects/ores.compass/compass.sh review reply <N> <comment-id> "<message>"
    
  1. Resolve threads and record the round in the task's * Review table:

    ./projects/ores.compass/compass.sh review resolve <N>
    

Recipes

Reference

Emacs 29.1 (Org mode 9.6.6)