PR Address Review

Table of Contents

When to use this skill

Review comments arrived on a PR: handle one complete round — sync, read, decide, fix, push, reply, resolve, record.

How to use this skill

  1. Gate — confirm there is a round to handle: compass review list <N> --detail. No comments yet, or the reviewer still running → stop and wait. Every comment replied and threads resolved → round already done; stop. Never sync/rebase when there is nothing to address — it churns CI and forces a force-push.
  2. Sync with main:

    ./projects/ores.compass/compass.sh pr sync
    
  1. Check CI before reading comments — a failure may supersede them:

    ./projects/ores.compass/compass.sh pr checks <N>
    
  1. Read every comment:

    ./projects/ores.compass/compass.sh review list <N> --detail
    
  1. Decide per comment — explicit accept or decline; never silently ignore.
  2. Fix — one commit per logical fix; never amend on a branch under review. Classify the round's fix with the pr-raise rule table and run only the matching checks locally before pushing — this is the only local verification a round gets, so don't skip it. Update the task's * Review table (step 7) for this round and include that in the same push as the fixes — never push a bookkeeping-only commit after this round's CI has already gone green; that wastes a full CI cycle recording something with no code content. Push.
  3. Reply to every comment — accepted: "Fixed in <sha> — …"; declined: "Not changed. <reason>":

    ./projects/ores.compass/compass.sh review reply <N> <comment-id> "<message>"
    
  1. Resolve threads — already recorded in the * Review table and pushed together with step 5's fixes, not as a separate follow-up commit:

    ./projects/ores.compass/compass.sh review resolve <N>
    

    Replying and resolving are GitHub API calls, not commits — they don't trigger CI. Once this round's CI is green and the reviewer approves, task/story bookkeeping should already be in place from before the PR was raised (see agile-close-task) — merge immediately with pr-merge, no additional commits.

Recipes

Reference

Emacs 29.3 (Org mode 9.6.15)