Task: Fix code review comments for librarian
This page documents a task in the Librarian polish story. It captures the goal, current status, acceptance, and any notes or results.
Goal
Address the PR-review feedback on the Data Librarian landed in sprint 09.
Status
| Field | Value |
|---|---|
| State | DONE |
| Parent story | Librarian polish |
| Now | Completed 2026-01-27. |
| Waiting on | None. |
| Next | None. |
| Last touched | 2026-01-27 |
Acceptance
- Domain view + edit work.
- Tree exposes dimension nodes as filters.
- Dependency diagram consumes the new message.
- Country-flag mapping loads correctly after restart (force-load on first use).
- Header colour distinct from row colour (raised as follow-up).
- Publish-failure errors visible (raised as follow-up story).
- Crypto vs country flag namespace clash (e.g.
AE) raised.
Plan
Captured during execution; cleared into the parent story on close.
Notes
Some review items raised in PR #348 ran out of Claude Code token budget; this task closes most of them, raises follow-ups for the rest.
Result
Most review feedback addressed; the rest carry forward as named stories.