Story: Engineering hygiene
Table of Contents
This page documents a story in Sprint 11. It captures the goal, current status, acceptance criteria, and the tasks that compose it.
Goal
Three independent hygiene strands: clear the backlog of past PR review
comments, harden apt-get against transient failures, and restore vcpkg
binary caching after the x-gha backend was silently removed upstream.
Status
| Field | Value |
|---|---|
| State | DONE |
| Parent sprint | Sprint 11 |
| Now | Completed 2026-02-06. |
| Waiting on | None. |
| Next | None. |
| Last touched | 2026-02-06 |
Acceptance
- Past review comments cleared.
- apt-get has exponential-backoff retry.
- vcpkg cache hit-rate restored.
Tasks
| Task | State | Start | End | Description |
|---|---|---|---|---|
| Address past review comments | DONE | 2026-05-19 | 2026-01-29 | Clear backlog of review comments from PRs #389 and #387: header-state restoration, DataLibrarianWindow optimisation, bundle validation messages, dataset_protocol helpers extracted, ORE CMake dependency cleanup, doc pruning. |
| Fix apt-get failures on nightly build | DONE | 2026-05-19 | 2026-02-05 | Exponential-backoff retry loop in install_debian_packages.sh (5 retries, 5s start); Acquire::Retries=3; –with-valgrind flag for nightly. |
| Fix vcpkg caching (x-gha removed upstream) | DONE | 2026-05-19 | 2026-02-06 | Replace the silently-removed x-gha vcpkg binary-cache backend with the files provider backed by actions/cache@v4 across 5 workflow files; saves ~21 min per build. |
Decisions
- Clear review comments first
- technical-debt headwind would have interfered with the multi-tenant work; better to flush it first.
- Files-based cache via actions/cache@v4
- the
x-ghaupstream removal was silent; this is the recommended replacement and survives upstream churn better.
Out of scope
- Migrating off
install_debian_packages.shto a container image.
See also
None.