Task: Address past review comments
This page documents a task in the Engineering hygiene story. It captures the goal, current status, acceptance, and any notes or results.
Goal
Clear the backlog of review comments from PRs #389 and #387 across Qt, DQ, and ORE.
Status
| Field | Value |
|---|---|
| State | DONE |
| Parent story | Engineering hygiene |
| Now | Completed 2026-01-29. |
| Waiting on | None. |
| Next | None. |
| Last touched | 2026-01-29 |
Acceptance
- Qt MDI windows (ChangeReasonCategory, ChangeReason, Country, Currency, DataLibrarian, DatasetBundle, OriginDimension) restore header state robustly; fall back gracefully when settings are corrupted.
DataLibrarianWindow::getDatasetsUnderNodeoptimised to avoid redundant iterations.- Dataset-bundle validation pinpoints the missing field.
- Batch-delete error messages include the failing bundle codes.
- DQ
write_dataset/read_datasethelpers moved from anonymous namespace intodataset_protocol.hpp(200 lines of duplicated serialisation gone). - ORE CMake deps cleaned up: removed
ores.variability.lib,ores.comms.lib,sqlgen::sqlgen,faker-cxx,libfort::fort; addedores.logging.lib+ores.platform.lib. - Doc/agile cleanup: pruned outdated entries from
product_backlog.org.
Plan
Captured during execution; cleared into the parent story on close.
Notes
First task of the sprint; clears the technical-debt headwind before the multi-tenant work starts.
Result
Past review comments addressed; codebase ready for the tenancy work.