Task: Apply view_group tabs to the currency entity (pilot)

Table of Contents

This page documents a task in the Codegen support for view groups (Qt detail-dialog tabs) story. It captures the goal, current status, acceptance, and any notes or results.

Goal

Restore currency's original four-tab detail dialog (General, Formatting, Rounding, Provenance) using the new view_group codegen support, proving it out end-to-end on the entity that motivated it.

Status

Field Value
State DONE
Parent story Codegen support for view groups (Qt detail-dialog tabs)
Now Nothing.
Waiting on Nothing.
Next Nothing.
Last touched 2026-07-10

Acceptance

  • [X] Currency's entity_org model (projects/ores.refdata/modeling/ores.refdata.currency.org) got view_group values on its *** Detail fields rows matching the recovered pre-codegen grouping exactly:
    • General: ISO Code, Name, Numeric Code, Asset Class, Market Tier
    • Formatting: Symbol, Fraction Symbol, Fractions Per Unit, Format
    • Rounding: Rounding Type, Rounding Precision
    • (Provenance is generic/already handled — not part of Detail fields, no change needed there.)
  • [X] Regenerated CurrencyDetailDialog.{hpp,cpp,ui} via codegen and confirmed live in the running app: all four tabs, correct order, correct fields per tab — verified via the test_scenario below (6/6 steps PASSED), not just eyeballed once.
  • [X] No other currency-adjacent generated file changed as a side effect of the view_group work itself — confirmed via compass codegen entity generate currency --diff --address ores.cpp.qt showing only CurrencyDetailDialog.ui changed. (A second, unrelated fix landed on this same branch afterward — ClientCurrencyModel.cpp regenerated separately to surface server-side failures as UI-visible errors, discovered while testing this task live; tracked in its own commit, not part of the view_group change itself.)
  • [X] A test_scenario doc created and run through the QA Validation Runner to verify this live: Verify currency's restored General/Formatting/Rounding/Provenance tabs — 6/6 steps PASSED.

Plan

Located currency's entity_org model (projects/ores.refdata/modeling/ores.refdata.currency.org), added view_group values to its Detail fields table matching the pre-codegen grouping recovered earlier from git history, regenerated via compass codegen entity generate currency --address ores.cpp.qt, rebuilt, and verified live via the QA Validation Runner.

While testing live, discovered the currency list was rendering blank with no error — traced to a real backend SQL error (a stale DB schema missing a column the current C++ repository query expects) being silently swallowed by the Qt client rather than shown to the tester. Root-caused and fixed separately (see the story's sibling commit) since it's a systemic codegen-template gap unrelated to view_group specifically, not scoped to this task — but blocked live verification of this task until fixed, so it's noted here for the record. The underlying stale-schema issue itself was resolved by recreating the environment's database and reprovisioning its Barclays Plc tenant.

Notes

Test Scenarios

Manual QA scenarios (scaffolded via compass add test_scenario, run through the QA Validation Runner panel) that verify this task. Link new ones here as they're created; the scenario doc itself links back via its "Verifies task" field.

Scenario State Notes
Verify currency's restored General/Formatting/Rounding/Provenance tabs PASSED 6/6 steps passed.

PRs

PR Title
   

Review

Comment summary File Decision Notes
       

Result

Currency's detail dialog now shows its original four tabs (General/Formatting/Rounding/Provenance) again via the new view_group codegen support, verified live end-to-end (6/6 test steps PASSED, screenshot attached to the scenario doc). Also directly caused the discovery and fix of a real, systemic bug (server-side failures silently rendering as empty lists rather than UI-visible errors) — see the story-level commit for details.

Emacs 29.3 (Org mode 9.6.15)