Story: Hotfix: the marketdata offset field has no name

Table of Contents

This page documents a story in Sprint 27. It captures the goal, current status, acceptance criteria, and the tasks that compose it.

1. Goal

Let ores.marketdata.core.tests compile, so a full build reaches 100% on main.

2. Status

Field Value
State DONE
Parent sprint Sprint 27
Now Nothing.
Waiting on Nothing.
Next Nothing.
Last touched 2026-10-09

3. Acceptance

  • datum_ore_key_codec_tests.cpp names a field enum member that exists.
  • The ORE key the commodity calendar spread option case writes is still offset.
  • A full build completes.

4. Tasks

Task State Start End Description
Scaffold story: Hotfix: the marketdata offset field has no name DONE 2026-10-09 2026-10-09 Story scaffolding rides this task: documents, sprint wiring, and the scaffold PR. Close it before merging that PR.
Implement Hotfix: the marketdata offset field has no name DONE   2026-10-09 Initial task for: Hotfix: the marketdata offset field has no name

5. Decisions

  • The ORE key stays offset. a6f1f9b570 renamed the C++ field to spread_offset because something else in the process reads the name it carries: the PostgreSQL store, where offset is reserved. Its model records that ORE's own spelling of the key is unchanged, so only the enum member moves and the JSON key this test writes stays offset.

6. Out of scope

  • The rename itself. a6f1f9b570 and 4ec27d8c47 decided it. This restores the one caller that was left behind.

7. Result

Done. The stale reference was line 567 of projects/ores.marketdata/core/tests/datum_ore_key_codec_tests.cpp, the only one in the tree. ./compass.sh build completes to 100%.

Emacs 29.3 (Org mode 9.6.15)