Task: Implement Hotfix: the marketdata offset field has no name
Table of Contents
This page documents a task in the Hotfix: the marketdata offset field has no name story. It captures the goal, current status, acceptance, and any notes or results.
1. Goal
Make the commodity calendar spread option case in
datum_ore_key_codec_tests.cpp read the field enum member that exists, so the
translation unit compiles and the suite links.
2. Status
| Field | Value |
|---|---|
| State | DONE |
| Parent story | Hotfix: the marketdata offset field has no name |
| Now | Nothing. |
| Waiting on | Nothing. |
| Next | Nothing. |
| Last touched | 2026-10-09 |
3. Acceptance
datum_ore_key_codec_tests.cppcompiles.- The JSON key the case writes is unchanged.
./compass.sh buildcompletes.
4. Plan
fl::offset becomes fl::spread_offset. The field enum in
ores.marketdata.api/datum/schema.hpp declares spread_offset and no offset,
and market_series_identity.hpp records why: offset is a reserved word in
PostgreSQL and the identity column the generator writes takes the qualified
name. The JSON key the case assigns is a separate string and stays offset,
which is ORE's own spelling of the key.
5. Measurements
| What | Value | Command | Commit |
|---|---|---|---|
stale fl::offset references in the tree |
1 | git grep -n "fl::offset" -- projects/ |
b70b9a18d6 |
6. Notes
The compiler named the fix: no member named 'offset' in
'ores::marketdata::datum::field'; did you mean 'timex::offset', which is the
system struct in bits/timex.h and not ours.
7. Test Scenarios
| Scenario | State | Notes |
|---|---|---|
8. PRs
| PR | Title |
|---|---|
9. Review
| Comment summary | File | Decision | Notes |
|---|---|---|---|
10. Result
One line changed. ores.marketdata.core.tests links, and the full build reaches
100%.