Story: Hotfix: the party role test asserts a dropped column
Table of Contents
This page documents a story in Sprint 27. It captures the goal, current status, acceptance criteria, and the tasks that compose it.
1. Goal
Let ores.trading.api.tests pass, so the trade party role suite reports on the code rather than on a column the model no longer has.
2. Status
| Field | Value |
|---|---|
| State | DONE |
| Parent sprint | Sprint 27 |
| Now | Nothing. |
| Waiting on | Nothing. |
| Next | Nothing. |
| Last touched | 2026-10-09 |
3. Acceptance
- The empty-vector case asserts a header the table still renders.
- ores.trading.api.tests passes.
4. Tasks
| Task | State | Start | End | Description |
|---|---|---|---|---|
| Scaffold story: Hotfix: the party role test asserts a dropped column | DONE | 2026-10-09 | 2026-10-09 | Story scaffolding rides this task: documents, sprint wiring, and the scaffold PR. Close it before merging that PR. |
| Implement Hotfix: the party role test asserts a dropped column | DONE | 2026-10-09 | Initial task for: Hotfix: the party role test asserts a dropped column |
5. Decisions
- The case keeps its subject. The test is about a table rendering its header row when the vector is empty, which the generated converter does before it looks at the vector. The column it names is incidental, so the assertion moves to the anchor the table renders now rather than the case being deleted.
6. Out of scope
- The re-keying itself.
c73c71eadecided it and regenerated the table.
7. Result
Done. The assertion reads Trade ID, with a comment naming why the old header
went, and ores.trading.api.tests passes.