Task: Implement Hotfix: the party role test asserts a dropped column
Table of Contents
This page documents a task in the Hotfix: the party role test asserts a dropped column story. It captures the goal, current status, acceptance, and any notes or results.
1. Goal
Make the empty-vector case of trade_party_role_convert_empty_vector_to_table
assert a header the table still renders, so ores.trading.api.tests passes.
2. Status
| Field | Value |
|---|---|
| State | DONE |
| Parent story | Hotfix: the party role test asserts a dropped column |
| Now | Nothing. |
| Waiting on | Nothing. |
| Next | Nothing. |
| Last touched | 2026-10-09 |
3. Acceptance
- The case asserts the header the generated table writes.
ores.trading.api.testspasses.
4. Plan
The assertion moves from Counterparty ID to Trade ID, the anchor the role
hangs off now, and gains a comment naming why the old header went. The case
itself stays: it verifies that an empty vector still renders the header row,
which is a property of the converter and not of the column.
The generated table writes Trade ID, Role, Modified By, Version –
trade_party_role_table.cpp line 36.
5. Measurements
| What | Value | Command | Commit |
|---|---|---|---|
| headers the generated table writes | Trade ID, Role, Modified By, Version | git grep -n "Trade ID" -- projects/ores.trading/api/src/domain/trade_party_role_table.cpp |
395b099bd2 |
6. Notes
The stale assertion is a regression c73c71ea left behind: it removed the
counterparty columns from the model's display table and regenerated the
converter, but the case that names a column was not regenerated with it.
7. Test Scenarios
| Scenario | State | Notes |
|---|---|---|
8. PRs
| PR | Title |
|---|---|
9. Review
| Comment summary | File | Decision | Notes |
|---|---|---|---|
10. Result
One assertion and its comment changed. ores.trading.api.tests passes.